Skip to content

Rebuild dotc if new *.scala files are found in dotty/src #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2015

Conversation

DarkDimius
Copy link
Contributor

No description provided.

@DarkDimius
Copy link
Contributor Author

ping @VladUreche, I guess you could reuse this.

@DarkDimius
Copy link
Contributor Author

@smarter please review.

@smarter
Copy link
Member

smarter commented May 27, 2015

LGTM.

DarkDimius added a commit that referenced this pull request May 27, 2015
Rebuild dotc if new *.scala files are found in `dotty/src`
@DarkDimius DarkDimius merged commit 3940818 into scala:master May 27, 2015
@VladUreche
Copy link
Contributor

Thanks @DarkDimius! I keep an sbt ~package running during development, and it's fast enough for the miniboxing plugin. But I agree for a larger code base, like dotty, you don't want to build each change.

echo "new files detected. rebuilding"
cd $DOTTY_ROOT
sbt $2
touch "$1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to do this manually? At a first sight, sbt should update the jar file when rebuilding, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes sbt is smart enough to see that it does not need to rebuild the project, though timestamps changed. Eg if you make a change and revert it.

@allanrenucci allanrenucci deleted the dotc-improve branch December 14, 2017 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants